feature: support measure_ff and cc_prx gates#103
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2163 2201 +38
Branches 250 254 +4
=========================================
+ Hits 2163 2201 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yitchen-tim
reviewed
May 8, 2026
| self.simulation.evolve(self.context.pop_instructions()) | ||
| targets = self.context.get_qubits(qubits[0]) | ||
| outcome = self.simulation.measure(targets) | ||
| try: |
Contributor
There was a problem hiding this comment.
ff_name should not exist because IQM demands feedback key to be unique. So the behavior here is different from IQM's. Alternative is:
if ff_name in self.symbol_table:
raise ValueException()
self.context.declare_variable(ff_name, BitType(size=None))
yitchen-tim
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds two IQM classical-control gate wrappers:
measure_ff(a measurement that writes to a feedback key) andcc_prx(a classically-controlled prx gate guarded by that feedback key).Testing done:
tox passes.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.